feat: client unpause and client help #4630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
kostasrim
commented
Feb 19, 2025
kostasrim
commented
Feb 19, 2025
kostasrim
commented
Feb 19, 2025
src/server/server_family.cc
Outdated
Comment on lines
3226
to
3228
| std::unique_lock lk(client_pause_mu_); | ||
| client_pause_.store(true, std::memory_order_relaxed); | ||
| client_pause_fb_ = std::move(*pause_fb_opt); |
There was a problem hiding this comment.
Only this part changed semantically. The rest is moved/ small refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
client unpauseandclient help.Resolves #4628 and #3799