Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for manager handler #3222

Merged
merged 1 commit into from
Apr 24, 2024
Merged

test: add unit test for manager handler #3222

merged 1 commit into from
Apr 24, 2024

Conversation

BruceAko
Copy link
Contributor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@BruceAko BruceAko requested a review from a team as a code owner April 23, 2024 05:27
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.77%. Comparing base (570a37f) to head (f041879).
Report is 2 commits behind head on main.

❗ Current head f041879 differs from pull request most recent head d765e28. Consider uploading reports for the commit d765e28 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   52.82%   52.77%   -0.06%     
==========================================
  Files         192      192              
  Lines       20341    20341              
==========================================
- Hits        10746    10735      -11     
- Misses       8796     8802       +6     
- Partials      799      804       +5     
Flag Coverage Δ
unittests 52.77% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@BruceAko BruceAko requested a review from gaius-qi April 23, 2024 09:01
@BruceAko
Copy link
Contributor Author

@gaius-qi Updated now. PTAL.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 710f9f3 into dragonflyoss:main Apr 24, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants