Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blobfs): Update fs ops for fuse_backend_rs 0.12.0 #1659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

papazof
Copy link

@papazof papazof commented Dec 23, 2024

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

  1. Use the correct result types in blobfs for open and create with fuse_backend_rs 0.12.0
  2. Add missing dedup feature for storage crate dependency of rafs

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Fix `rafs` build by adding missing `dedup` feature for `storage` crate
dependency

Signed-off-by: Kostis Papazafeiropoulos <[email protected]>
Use the correct result types for `open` and `create` expected by the
`fuse_backend_rs` 0.12.0 `Filesystem` trait

Signed-off-by: Kostis Papazafeiropoulos <[email protected]>
@papazof papazof requested a review from a team as a code owner December 23, 2024 16:27
@papazof papazof requested review from imeoer, jiangliu and gaius-qi and removed request for a team December 23, 2024 16:27
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.05%. Comparing base (365f13e) to head (add72f1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
- Coverage   60.05%   60.05%   -0.01%     
==========================================
  Files         147      147              
  Lines       49624    49624              
  Branches    47078    47078              
==========================================
- Hits        29802    29800       -2     
- Misses      18040    18041       +1     
- Partials     1782     1783       +1     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants