[WIP]Support CRC32 validation for both RAFS V5 and V6. #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 13, 2025 16:28
Add method and flag to indicate whether chunk has CRC. Signed-off-by: Yang Kaiyong <[email protected]>
- Add crc32 chceker field to BlobInfo. - Add crc32 method to BlbChunkInfo. - Add crc32 algorithm implementation wiht crc-rs crate. - Add get crc32 checker method to BlobCache trait. Signed-off-by: Yang Kaiyong <[email protected]>
Add crc32 validation for chunks that include a CRC32 field Signed-off-by: Yang Kaiyong <[email protected]>
- Introduced a crc_enable option to the nydus builder. - Added support for generating CRC checksums when building images. Signed-off-by: Yang Kaiyong <[email protected]>
To enable CRC checksum validation for the V6 version, the following changes were made: - Removed the `HAS_CRC` flag from `BlobFeature`, as it is no longer needed. - Added support for setting the crc32 field in `BlobChunkInfoV2Ondisk`. Signed-off-by: Yang Kaiyong <[email protected]>
BraveY
requested review from
gaius-qi,
hsiangkao and
power-more
and removed request for
a team
added 2 commits
February 24, 2025 11:29
Add image crc checksum test in integration case to smoke test. Signed-off-by: Yang Kaiyong <[email protected]>
BraveY
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
In P2P transmission, errors in the pulled Chunk information may occur due to network issues or other reasons. To address this, CRC32 has been introduced to verify the integrity of Chunk data. Compared to the case without enabling verification, using CRC32 increases the processing time by approximately 5.6%, which is an acceptable overhead.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.