Noise analysis and other features and fixes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add noise analysis (initial version: integrated noise only); - add user documentation for the simulation settings (DC, AC and Noise); - increase the minimum width of the simulation settings window in order to fit all the descriptions (labels); - fix units of measurements for several simulation settings (DC and AC, from incorrect units of "seconds"); - properly set Pango Text Attribute Markup Language in oregano_error(), oregano_warning() and oregano_question(); - add auxiliary functions to schedule calls to oregano_error(), oregano_warning() and oregano_question() using the GLib function g_idle_add_full() (thanks Bernhard for the tip, this is a local ngspice_analysis resolution for drahnr#194); - some style improvements here and there; - insert the proper GNU copyright notice in new files (proper copyright information and full name is still missing for user "Michi" !); - update authors, copyright information and contact details in the GUI; - version bump. Signed-off-by: Guido Trentalancia <[email protected]> --- AUTHORS | 1 data/xml/sim-settings.ui | 566 +++- docs/user-docs/Simulation-Settings-HOWTO.md | 30 src/dialogs.c | 66 src/dialogs.h | 5 src/engines/netlist-helper.c | 10 src/engines/netlist-helper.h | 2 src/engines/ngspice-analysis.c | 98 src/engines/ngspice-watcher.c | 23 src/engines/ngspice-watcher.h | 23 src/engines/ngspice.c | 23 src/load-schematic.c | 81 src/log-interface.h | 25 src/plot.c | 32 src/save-schematic.c | 31 src/sim-settings-gui.c | 401 ++- src/sim-settings-gui.h | 46 src/sim-settings.c | 95 src/sim-settings.h | 37 src/simulation.h | 3 src/tools/cancel-info.c | 23 src/tools/cancel-info.h | 23 src/tools/thread-pipe.c | 29 src/tools/thread-pipe.h | 23 test/test-files/test_engine_ngspice_watcher/basic/result/actual.txt | 1176 ---------- test/test-files/test_engine_ngspice_watcher/error/step_zero/result/actual.txt | 5 test/test_engine_ngspice.c | 23 test/test_thread_pipe.c | 23 test/test_update_connection_designators.c | 24 wscript | 2 30 files changed, 1394 insertions(+), 1555 deletions(-)
drahnr
reviewed
Jun 20, 2017
src/dialogs.c
Outdated
| * The caller should schedule this function call using the GLib | ||
| * function g_idle_add_full(). | ||
| */ | ||
| gboolean oregano_schedule_error (gchar *msg) { oregano_error_with_title (msg, NULL); return FALSE; } |
There was a problem hiding this comment.
Wouldn't it better to do the scheduling implicitly? And maybe provide another func oregano_schedule_error_with_title?
|
|
||
| gtk_dialog_set_default_response (GTK_DIALOG (dialog), GTK_RESPONSE_OK); | ||
| gtk_dialog_set_default_response (GTK_DIALOG (dialog), GTK_RESPONSE_CLOSE); | ||
|
|
There was a problem hiding this comment.
Does this have any implications? I guess not since we do not check the the reutrn of gtk_dialog_run..
src/dialogs.c
Outdated
| * function g_idle_add_full(). | ||
| */ | ||
| gboolean oregano_schedule_question (gchar *msg) { oregano_question (msg); return FALSE; } | ||
|
|
There was a problem hiding this comment.
return should be G_SOURCE_REMOVE I think.
src/engines/netlist-helper.c
Outdated
| prop = part_get_property (part, "Frequency"); | ||
| if (prop) | ||
| sources_list = g_slist_append (sources_list, tmp); | ||
| } else |
There was a problem hiding this comment.
if the if clause has curly brackets, please also use for the else
|
@gtrentalancia just fix those few minor things and push to your branch, the commits will appear here :) |
added 5 commits
June 20, 2017 12:49
From now on tests should be run before pushing, but CI will check them anyways before the merge is authorized.
|
It would be great if you could do a |
to Bernhard Schuster for reviewing the latest patch): - add curly brackets to "else" statement whenever they are used for the corresponding "if" statement (netlist helper); - make sure oregano_schedule_question() returns the value of the answer; - fix the oregano_question() function by creating a dialog correctly and by properly getting the answer; - add two new functions to schedule calls to oregano_error_with_title() and oregano_warning_with_title() instead of just functions to schedule oregano_error() and oregano_warning().
Author: Bernhard Schuster <[email protected]> Date: Tue Jun 20 12:49:56 2017 +0200 test: get rid of unites From now on tests should be run before pushing, but CI will check them anyways before the merge is authorized.
- add noise analysis (initial version: integrated noise only); - add user documentation for the simulation settings (DC, AC and Noise); - increase the minimum width of the simulation settings window in order to fit all the descriptions (labels); - fix units of measurements for several simulation settings (DC and AC, from incorrect units of "seconds"); - properly set Pango Text Attribute Markup Language in oregano_error(), oregano_warning() and oregano_question(); - add auxiliary functions to schedule calls to oregano_error(), oregano_warning() and oregano_question() using the GLib function g_idle_add_full() (thanks Bernhard for the tip, this is a local ngspice_analysis resolution for drahnr#194); - some style improvements here and there; - insert the proper GNU copyright notice in new files (proper copyright information and full name is still missing for user "Michi" !); - update authors, copyright information and contact details in the GUI; - version bump. Signed-off-by: Guido Trentalancia <[email protected]> --- AUTHORS | 1 data/xml/sim-settings.ui | 566 +++- docs/user-docs/Simulation-Settings-HOWTO.md | 30 src/dialogs.c | 66 src/dialogs.h | 5 src/engines/netlist-helper.c | 10 src/engines/netlist-helper.h | 2 src/engines/ngspice-analysis.c | 98 src/engines/ngspice-watcher.c | 23 src/engines/ngspice-watcher.h | 23 src/engines/ngspice.c | 23 src/load-schematic.c | 81 src/log-interface.h | 25 src/plot.c | 32 src/save-schematic.c | 31 src/sim-settings-gui.c | 401 ++- src/sim-settings-gui.h | 46 src/sim-settings.c | 95 src/sim-settings.h | 37 src/simulation.h | 3 src/tools/cancel-info.c | 23 src/tools/cancel-info.h | 23 src/tools/thread-pipe.c | 29 src/tools/thread-pipe.h | 23 test/test-files/test_engine_ngspice_watcher/basic/result/actual.txt | 1176 ---------- test/test-files/test_engine_ngspice_watcher/error/step_zero/result/actual.txt | 5 test/test_engine_ngspice.c | 23 test/test_thread_pipe.c | 23 test/test_update_connection_designators.c | 24 wscript | 2 30 files changed, 1394 insertions(+), 1555 deletions(-)
to Bernhard Schuster for reviewing the latest patch): - add curly brackets to "else" statement whenever they are used for the corresponding "if" statement (netlist helper); - make sure oregano_schedule_question() returns the value of the answer; - fix the oregano_question() function by creating a dialog correctly and by properly getting the answer; - add two new functions to schedule calls to oregano_error_with_title() and oregano_warning_with_title() instead of just functions to schedule oregano_error() and oregano_warning().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only);
AC and Noise);
window in order to fit all the descriptions (labels);
settings (DC and AC, from incorrect units of
"seconds");
oregano_error(), oregano_warning() and oregano_question();
oregano_warning() and oregano_question() using the GLib
function g_idle_add_full() (thanks Bernhard for the tip,
this is a local ngspice_analysis resolution for oregano_warning popup - missing check for correct thread #194);
copyright information and full name is still missing for
user "Michi" !);
details in the GUI;
Signed-off-by: Guido Trentalancia [email protected]
AUTHORS | 1
data/xml/sim-settings.ui | 566 +++-
docs/user-docs/Simulation-Settings-HOWTO.md | 30
src/dialogs.c | 66
src/dialogs.h | 5
src/engines/netlist-helper.c | 10
src/engines/netlist-helper.h | 2
src/engines/ngspice-analysis.c | 98
src/engines/ngspice-watcher.c | 23
src/engines/ngspice-watcher.h | 23
src/engines/ngspice.c | 23
src/load-schematic.c | 81
src/log-interface.h | 25
src/plot.c | 32
src/save-schematic.c | 31
src/sim-settings-gui.c | 401 ++-
src/sim-settings-gui.h | 46
src/sim-settings.c | 95
src/sim-settings.h | 37
src/simulation.h | 3
src/tools/cancel-info.c | 23
src/tools/cancel-info.h | 23
src/tools/thread-pipe.c | 29
src/tools/thread-pipe.h | 23
test/test-files/test_engine_ngspice_watcher/basic/result/actual.txt | 1176 ----------
test/test-files/test_engine_ngspice_watcher/error/step_zero/result/actual.txt | 5
test/test_engine_ngspice.c | 23
test/test_thread_pipe.c | 23
test/test_update_connection_designators.c | 24
wscript | 2
30 files changed, 1394 insertions(+), 1555 deletions(-)