Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delegated admin account #78

Merged
merged 6 commits into from
Jul 31, 2024
Merged

delegated admin account #78

merged 6 commits into from
Jul 31, 2024

Conversation

jameslarrea
Copy link
Contributor

Allow the ability to deploy the stacksets using a delegated admin account https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/stacksets-orgs-delegated-admin.html

@jameslarrea jameslarrea requested a review from a team as a code owner July 30, 2024 04:23
cgeers
cgeers previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@cgeers cgeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the variable name could be clearer as delegated_admin instead of the more ambiguous delegated.

overall the change LGTM.

ravinadhruve10
ravinadhruve10 previously approved these changes Jul 30, 2024
View reviewed changes
@jameslarrea jameslarrea dismissed stale reviews from ravinadhruve10 and cgeers via ec77101 July 30, 2024 18:21
cgeers
cgeers previously approved these changes Jul 30, 2024
View reviewed changes
ravinadhruve10
ravinadhruve10 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM :)

@jameslarrea jameslarrea merged commit f3be96e into main Jul 31, 2024
5 checks passed
@jameslarrea jameslarrea deleted the delegated_admin_account branch July 31, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

@cgeers cgeers cgeers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslarrea @cgeers @ravinadhruve10