190 test task usermode #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanoBurrito
reviewed
Dec 1, 2023
docs/kernel/Initialization.md
Outdated
|
|
||
| ## Loading the kernel | ||
|
|
||
| The kernel is loaded by grub2, using the multibtoo2 specifications. |
There was a problem hiding this comment.
multiboo? sounds very spooky.
There was a problem hiding this comment.
ahaha i started it when during the halloween season, lol
| @@ -57,7 +57,7 @@ thread_t* create_thread(char* thread_name, void (*_entry_point)(void *), void* a | |||
| } | |||
|
|
|||
| // Every thread need it's kernel stack allocated (aka rsp0 field of the TSS) | |||
| new_thread->rsp0 = kmalloc(THREAD_DEFAULT_STACK_SIZE); | |||
| new_thread->rsp0 = kmalloc(THREAD_DEFAULT_STACK_SIZE) + THREAD_DEFAULT_STACK_SIZE; | |||
There was a problem hiding this comment.
might be useful to allocate stacks from the vmm, and then you can pass in a flag like VM_STACK - which can automatically return the top address for you (to avoid future errors like this one).
There was a problem hiding this comment.
this is a cool idea!
i'll implement it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #190