Add line handling in fb_printStr #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/kernel/framebuffer/framebuffer.c
Outdated
| void _fb_printStr( const char *string, uint32_t fg, uint32_t bg ) { | ||
| _fb_printStrAt(string, 0, cur_fb_line, fg, bg); | ||
| cur_fb_line++; | ||
| if ( cur_fb_line > framebuffer_data.number_of_lines ) { |
There was a problem hiding this comment.
shouldnt this be >=?
| @@ -74,15 +74,16 @@ void logline(log_level_t level, const char* msg){ | |||
| fbCurrentLine++; | |||
| } | |||
| else { | |||
| _fb_printStr(logLevelStrings[level], 0, fbCurrentLine, 0xFFFFFFFF, 0); | |||
| _fb_printStr(msg, logLevelStrLen, fbCurrentLine, 0xFFFFFFFF, 0); | |||
| //TODO: fbCurrentLine should be aligned with cur_fbLine in the framebuffer case. | |||
There was a problem hiding this comment.
hmm yeah, this is an interesting one - I remember doing that because there no state tracking a current line number for the terminal output.
Now that the framebuffer keeps track of that itself, fbCurrentLine can be removed I reckon, and just use the new codepath. Log messages will work nicely with other things that print directly to the framebuffer now too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #92