[ios_zip_validation] Validate zip #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschuls
requested changes
Feb 25, 2021
…dation # Conflicts: # iOS/Multiplatform Redux Sample/Multiplatform Redux Sample/Resources/en.lproj/Localizable.strings
|
Code Climate has analyzed commit ce3aede and detected 0 issues on this pull request. View more on Code Climate. |
tschuls
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
@Nils-Becker my understanding of the problem is:
- limiting the number of digits to 4
- not allowing back navigation if there is no valid zip
-> I did Add the limitation of 4 digits to android as well, the second point I handled in the State and reused it on both platforms. Is it okay with you?
|
I think there should be a way to cancel changing the zip code in the settings. Maybe we could have a "save" button in the upper right corner that is only enabled if the entry is valid and navigating back always discards your changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1199509904376633/1199959636277655/f