Feature/play integrity improvements #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lailabecker
commented
Aug 8, 2024
•
lailabecker
commented
- Fixes GooglePlayIntegrityAttestationVerifier does not set verified_data #12
- Adds additional configuration options for the play integrity verifier
melbic
requested changes
Aug 12, 2024
.github/workflows/python-tests.yml
Outdated
| @@ -14,7 +14,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: [3.8] | |||
| python-version: [3.11] | |||
There was a problem hiding this comment.
Let's try directly with Python 3.12 or did you already do that and it failed?
There was a problem hiding this comment.
Maybe we should also adjust it in the Pipfile...
Comment on lines
36
to
40
| def __convert_signing_digest(self, hex: str): | ||
| sanitized = hex.replace(':', '') | ||
| digest_bytes = bytearray.fromhex(sanitized) | ||
| base64Signature = base64.urlsafe_b64encode(digest_bytes).decode() | ||
| return base64Signature.replace('=', '') |
There was a problem hiding this comment.
That could/should be static, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.