Add "Show desktop" button #169

xoascf · 2021-11-19T05:43:10Z

Fixes:

~~Uses correct checkered background~~ (already done in Fix issues in XP classic theme #248)
Closes add visible desktop button on bottom right like in win 7 pls #84

Small issues:

Does not keep the button state when the desktop is shown
Not fully tested, Peek function may not work occasionally on Windows 7

xoascf · 2021-11-23T19:15:45Z

RetroBar/Controls/ShowDesktopButton.xaml.cs

+
+        private void ToggleDesktop()
+        {
+            NativeMethods.SendMessage(WindowHelper.FindWindowsTray(IntPtr.Zero),


I think it should be better to add this to ManagedShell instead of being here.

I agree. This could complement the other Aero Peek helper methods in ManagedShell.

Jawomo · 2022-03-22T08:04:58Z

@xoascf
@dremin

Maybe using https://github.com/michaelnoonan/inputsimulator
methods to send Win + D fixes the freeze problems.

They use NativeMethods.SendInput.

xoascf · 2022-03-22T13:59:51Z

Maybe using https://github.com/michaelnoonan/inputsimulator methods to send Win + D fixes the freeze problems.

They use NativeMethods.SendInput.

Thanks, but I don't want to use the keyboard shortcuts, as I know some people like to override the default shortcuts with custom ones. I will look into this situation a bit anyway.

Jawomo · 2022-03-23T18:31:36Z

Tested the #305 action build and have no issues with the desktop button so far. Windows 11 Pro

xoascf · 2022-07-09T20:16:27Z

RetroBar/Controls/TaskList.xaml.cs

@@ -143,5 +143,24 @@ private void TasksScrollViewer_PreviewMouseWheel(object sender, System.Windows.I
                e.Handled = true;
            }
        }
+
+        public bool AreAllWindowsMinimized()


@dremin, is it possible that we need to bind AreAllWindowsMinimized to the ShowDesktop Checked state, or is there a better way to detect when all windows are minimized?

I don't think you'll need to check if windows are minimized. From testing it seems like Explorer sets the desktop as the foreground window when "show desktop" is "enabled", and then considers it "enabled" until the desktop is no longer the foreground window. Once another window is foreground, toggling "show desktop" will show the desktop again rather than restore the windows. So basically once we enable show desktop, we want to keep the button checked until the foreground window changes.

There are a couple ways to do this, one being an approach similar to FullScreenHelper that polls GetForegroundWindow() every 100ms. Another idea that might be cleaner is to add an event to TasksService on shell hook messages that RetroBar could add a handler for (maybe FullScreenHelper could even be refactored to use this down the road if appropriate).

@xoascf Would you like me to help with the above to get this finished up?

Oh that would be perfect, this week I tried to add it in ManagedShell but I don't quite understand how to do it as you described above, I would be very grateful if you could do it for me, maybe later changes can be made if needed or requested for some themes.

The "Allow edits..." option is enabled, you can make the changes you want in this PR or separately, @dremin.

It seems that the behavior varies for certain themes:

In Windows 95 (and presumably the same for classic pre-7 themes): The button appears pressed when all windows are minimized (either with the button itself or with a keyboard shortcut to minimize them) and if the desktop is active after that (if the desktop is just foregrounded without any minimized windows, it's not going to appear as pressed).

In Windows 7 (and later): The button does not appear pressed when all windows are minimized or after you click it.

In both cases, it seems that the value (all minimized windows) is used for the context menu options, this seems to be especially useful for toggling them in #461.

@xoascf cairoshell/ManagedShell#74 is the ManagedShell support for this. Would you like me to wait to commit the RetroBar changes until a ManagedShell build is available on NuGet?

is the ManagedShell support for this. Would you like me to wait to commit the RetroBar changes until a ManagedShell build is available on NuGet?

That would be preferable.

@xoascf Just pushed the changes.

Thanks @dremin, by the way, the Show desktop button is not selected or deselected when using the shortcut to show the desktop with Win + D. Is this by design?

@xoascf Yeah, that is expected. I didn't add any handling for WM_COMMAND but will look into it. I don't think that should block this though.

codezi · 2022-09-04T09:23:56Z

Hope that is complete soon.

som3rando · 2023-02-02T18:23:15Z

Not fully tested, Peek function may not work occasionally on Windows 7

@xoascf I am interested in testing you fork on a unused windows 7 pc so I can encounter this issue and try to help you fix it.

xoascf · 2023-02-02T19:01:05Z

Alright @som3rando, let me fix this real quick.

som3rando · 2023-02-02T21:47:21Z

Had difficulties with the pc so i switched to a VM, and i believe i found a issue with the peek feature wich happens when you interact with the original peek function and switch back to retrobar. To fix the issue I had to delete appdata and restart.
This issue only shows up on windows 7 and doesn't show up on event viewer.
Video:https://youtu.be/7QA5hUgsOHs
VM Logs with issue.log
I will edit this comment with more issues if i find them.
When peeking desktop and clicking the desktop button the desktop will continue peeking until you move you mouse away.
also a recommendation to add a timer for 1-2 sec on peeking the desktop so it doesn't accidentally trigger
the desktop button keeps the pressed state but i assume that is "Does not keep the button state when the desktop is shown"

xoascf · 2023-03-21T05:42:55Z

Ok, I'm not sure if we will continue to support Windows 7, it would be better to finish this and if a solution is found, implement it in the future.

dremin · 2023-04-23T18:16:52Z

I'm working on some additional tweaks to the appearance to better match what I am seeing in Memphis build 1400 and NT 5 build 1796, as well as some improvements to the XP themes.

Where does the peek feature currently stand? It seems to be working great for me.

dremin · 2023-04-23T21:32:28Z

@xoascf I think this is good to go. What do you think?

xoascf · 2023-04-24T06:07:04Z

@xoascf I think this is good to go. What do you think?

Yes, this looks pretty good already, thanks for your patience and cooperation.
Let's merge it for now, and if there are any issues, we'll fix them in another PR.

xoascf mentioned this pull request Nov 22, 2021

Add "Show the desktop" shortcut, and this annoying gap. #173

Closed

xoascf commented Nov 23, 2021

View reviewed changes

xoascf force-pushed the show-desktop-button branch from ebc500f to 9e553de Compare November 24, 2021 21:49

xoascf force-pushed the show-desktop-button branch from aaeeb34 to 7a0369f Compare December 20, 2021 18:53

xoascf self-assigned this Dec 20, 2021

This comment was marked as outdated.

Sign in to view

xoascf force-pushed the show-desktop-button branch from 83f78f9 to 7a0369f Compare January 10, 2022 07:25

This comment was marked as outdated.

Sign in to view

xoascf mentioned this pull request Mar 22, 2022

Add Windows Vista Classic theme #296

Merged

xoascf closed this Mar 22, 2022

xoascf force-pushed the show-desktop-button branch from 67e0ad3 to 128280b Compare March 22, 2022 03:55

xoascf reopened this Mar 22, 2022

xoascf mentioned this pull request Mar 22, 2022

Task and Toolbar icons blurry, low res #289

Closed

xoascf commented Jul 9, 2022

View reviewed changes

xoascf force-pushed the show-desktop-button branch from a59483f to 9c52bd1 Compare July 15, 2022 01:24

xoascf force-pushed the show-desktop-button branch from 499a282 to cffac80 Compare September 7, 2022 23:29

xoascf force-pushed the show-desktop-button branch 2 times, most recently from e552fd2 to f4e8765 Compare November 6, 2022 05:28

1280px mentioned this pull request Jan 1, 2023

Add quick back to desktop on setting #495

Closed

xoascf force-pushed the show-desktop-button branch from d9cabf3 to a3a6f97 Compare February 2, 2023 19:06

xoascf force-pushed the show-desktop-button branch from a3a6f97 to 4cd8adc Compare March 21, 2023 05:42

Add Show desktop button

6817833

xoascf added 4 commits March 23, 2023 19:38

Fix desktop button style for System theme

68fb686

Add "Show desktop" button styles

8e37e4c

Add "Show desktop" button style for Vista themes

b257390

Add "Show desktop" button to preview

a89de8d

xoascf force-pushed the show-desktop-button branch from 4cd8adc to a89de8d Compare March 24, 2023 00:41

Deselect show desktop when switching windows

d9e7724

Improve show desktop button across themes

bc1d9a7

xoascf marked this pull request as ready for review April 24, 2023 05:59

xoascf merged commit 1381e4c into dremin:master Apr 24, 2023

xoascf deleted the show-desktop-button branch April 24, 2023 06:07

xoascf mentioned this pull request Sep 12, 2023

Usability: Show Desktop Button on the Bottom Right corner should be Borderless #680

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "Show desktop" button #169

Add "Show desktop" button #169

xoascf commented Nov 19, 2021 •

edited

Loading

xoascf Nov 23, 2021

dremin Nov 23, 2021

This comment was marked as outdated.

This comment was marked as outdated.

Jawomo commented Mar 22, 2022 •

edited

Loading

xoascf commented Mar 22, 2022

Jawomo commented Mar 23, 2022 •

edited

Loading

xoascf Jul 9, 2022

dremin Jul 13, 2022

dremin Mar 30, 2023

xoascf Mar 30, 2023

xoascf Mar 30, 2023 •

edited

Loading

dremin Apr 21, 2023

xoascf Apr 21, 2023

dremin Apr 21, 2023

xoascf Apr 21, 2023 •

edited

Loading

dremin Apr 21, 2023

codezi commented Sep 4, 2022

som3rando commented Feb 2, 2023 •

edited

Loading

xoascf commented Feb 2, 2023

som3rando commented Feb 2, 2023 •

edited

Loading

xoascf commented Mar 21, 2023

dremin commented Apr 23, 2023

dremin commented Apr 23, 2023

xoascf commented Apr 24, 2023

Add "Show desktop" button #169

Add "Show desktop" button #169

Conversation

xoascf commented Nov 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

Jawomo commented Mar 22, 2022 • edited Loading

xoascf commented Mar 22, 2022

Jawomo commented Mar 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xoascf Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xoascf Apr 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codezi commented Sep 4, 2022

som3rando commented Feb 2, 2023 • edited Loading

xoascf commented Feb 2, 2023

som3rando commented Feb 2, 2023 • edited Loading

xoascf commented Mar 21, 2023

dremin commented Apr 23, 2023

dremin commented Apr 23, 2023

xoascf commented Apr 24, 2023

xoascf commented Nov 19, 2021 •

edited

Loading

Jawomo commented Mar 22, 2022 •

edited

Loading

Jawomo commented Mar 23, 2022 •

edited

Loading

xoascf Mar 30, 2023 •

edited

Loading

xoascf Apr 21, 2023 •

edited

Loading

som3rando commented Feb 2, 2023 •

edited

Loading

som3rando commented Feb 2, 2023 •

edited

Loading