Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Implement theme customization feature. #957

Closed
wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2024

This PR is closed, as it is not a planned feature for RetroBar. You can use and modify the code on your own projects if you want.

What is this?
This is a feature for RetroBar that allows the customization of themes.
This version is working and can be used if someone wants to test it.
The goal is to allow user to modify themes directly from RetroBar settings.
Theme customizations are not saved to the original themes, instead they are saved to ThemeCustomizations.json.

Screenshot of current state:
1

TODO:
TODO: Add localization
TODO: Add better support for linear gradient colors
TODO: Clean and optimize code

MKKNinetyTwo added 3 commits November 17, 2024 16:50
-Fix grammar
-Replace few strings with Windows original versions
-Remove hotkeys (alt+_something) that do not exist in the translated sentence
-Fix hotkeys that can be fixes for the translation (use same hotkey as English translation uses)
@ghost ghost changed the title Implement theme customization feature. [DRAFT] Implement theme customization feature. Nov 17, 2024
@ghost
Copy link
Author

ghost commented Nov 17, 2024

List of some related issues\requests I found:

#901
#900
#850
#776
#423
#265

@xoascf
Copy link
Collaborator

xoascf commented Nov 19, 2024

It looks interesting, but for now the program has to fulfill a precise function, RetroBar is made to create a taskbar with specific themes and change basic settings, it does not create the themes, that depends solely on the designer's ability to edit XAML, otherwise it would be overkill. If submodules or plugins make it into RetroBar, something like this would come in handy, but for now it is just a block with appropriate dependencies to work as a taskbar replacement.

By the way, it would be preferable not to use other Git identities that have not worked on the code to commit to the repository.

@ghost
Copy link
Author

ghost commented Nov 19, 2024

It looks interesting, but for now the program has to fulfill a precise function, RetroBar is made to create a taskbar with specific themes and change basic settings, it does not create the themes, that depends solely on the designer's ability to edit XAML, otherwise it would be overkill. If submodules or plugins make it into RetroBar, something like this would come in handy, but for now it is just a block with appropriate dependencies to work as a taskbar replacement.

By the way, it would be preferable not to use other Git identities that have not worked on the code to commit to the repository.

Ok, thanks for the feedback :)

I will leave this here if someone wants to use it in the future. The code on this PR is free for everyone to modify/copy/use as they see fit.

Closed as not planned feature.

@ghost ghost closed this Nov 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants