[SingleStore] Add SingleStore connector #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rodriguespn
force-pushed
the
feature/new-dialect-singlestore
branch
2 times, most recently
from
86aa47e to
78db5cf
Compare
Rodriguespn
force-pushed
the
feature/new-dialect-singlestore
branch
from
78db5cf to
b813ee5
Compare
|
Starting my review today |
|
I'll resolve conflicts while doing my review, so no action is needed from your side |
…to feature/new-dialect-singlestore
…to feature/new-dialect-singlestore
Added query header for future logging of integration usage
Using database for tests and remove datetime and json from singlestore allTypes test on push
Added query header for future logging of integration usage
Using database for tests and remove datetime and json from singlestore allTypes test on push
Rodriguespn
force-pushed
the
feature/new-dialect-singlestore
branch
from
feb0e60 to
e9db7f1
Compare
…ore-labs/s2-drizzle-orm-dev into feature/new-dialect-singlestore
…to feature/new-dialect-singlestore
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add SingleStore support to Drizzle ORM. SingleStore is a distributed SQL database that unifies both transactional and analytical workloads. It is largely compatible with MySQL, but there are some incompatibilities and additional features that are supported.
Key differences between MySQL vs SIngleStore Integration Tests
serialcolumn type only assures uniqueness of the column values. The tests were modified to (set operation tests in particular) to expect SingleStore-specific behavior, by adding anORDER BYinstruction to every select instruction.ORDER BYandLIMITcannot be chained together.intersectAllandexceptAlltests since these operations are not supported by SIngleStoreisolationLevelconfig and tests as singlestore only supports oneisolationLevelTests results for SingleStore
Drizzle-kittests resultDrizzle-ormtests resultDrizzle-ormtype tests resultIntegration-testsresultsSide notes
There are some SingleStore-specific operations, such as
attach/detach,create/drop milestoneandoptimizeTablefor column stores tables, that are implemented ondrizzle-orm/src/singlestore-corebut not ondrizzle-kit. There are also no integration tests for these operations. This is a known issue and should be fixed in the upcoming releases.The relational tests that included nested selects with aggregations functions were skipped since SingleStore doesn't support it