Use Playwright github reporter in CI #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongrich
force-pushed
the
hongrich/playwright-github-reporter
branch
from
f30873e to
fe5b5b3
Compare
ajhyndman
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Github Actions CI, there is no colour which makes "expected failures" (green x in terminal) look like real failures (red x in terminal). Playwright has a built-in
githubreporter and we can conditionally use it in CI as shown in https://playwright.dev/docs/test-reporters#github-actions-annotationsThis works more like the
dotreporter when things are working properly (but only prints an entire row at a time) and adds an annotation to the pull request when there is a failure.A successful run https://github.com/dropbox/ttvc/actions/runs/9229125586/job/25394647024?pr=89
A failure run and inline annotation https://github.com/dropbox/ttvc/actions/runs/9229194092/job/25394874559?pr=89
