Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup feedback strings to use consistent quotes #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup feedback strings to use consistent quotes #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/feedback.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ feedback =
default_feedback:
warning: ''
suggestions: [
"Use a few words, avoid common phrases"
"No need for symbols, digits, or uppercase letters"
'Use a few words, avoid common phrases'
'No need for symbols, digits, or uppercase letters'
]

get_feedback: (score, sequence) ->
Expand Down Expand Up @@ -59,21 +59,21 @@ feedback =
]

when 'sequence'
warning: "Sequences like abc or 6543 are easy to guess"
warning: 'Sequences like abc or 6543 are easy to guess'
suggestions: [
'Avoid sequences'
]

when 'regex'
if match.regex_name == 'recent_year'
warning: "Recent years are easy to guess"
warning: 'Recent years are easy to guess'
suggestions: [
'Avoid recent years'
'Avoid years that are associated with you'
]

when 'date'
warning: "Dates are often easy to guess"
warning: 'Dates are often easy to guess'
suggestions: [
'Avoid dates and years that are associated with you'
]
Expand Down Expand Up @@ -103,14 +103,14 @@ feedback =
suggestions = []
word = match.token
if word.match(scoring.START_UPPER)
suggestions.push "Capitalization doesn't help very much"
suggestions.push 'Capitalization doesn\'t help very much'
else if word.match(scoring.ALL_UPPER) and word.toLowerCase() != word
suggestions.push "All-uppercase is almost as easy to guess as all-lowercase"
suggestions.push 'All-uppercase is almost as easy to guess as all-lowercase'

if match.reversed and match.token.length >= 4
suggestions.push "Reversed words aren't much harder to guess"
suggestions.push 'Reversed words aren\'t much harder to guess'
if match.l33t
suggestions.push "Predictable substitutions like '@' instead of 'a' don't help very much"
suggestions.push 'Predictable substitutions like "@" instead of "a" don\'t help very much'

result =
warning: warning
Expand Down