handle unknown index types gracefully in iUtils #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @xvrl, could you please take a look when you get a chance? |
|
Hi @alperkokmen, I'm not sure I'm the best person to review this. @drcrallen looks like you've made changes to this logic before, mind taking a look? |
|
just came across a new issue (#19) that these changes would take care of. @drcrallen, could you please take a look? |
|
bump – @drcrallen, could you please take a look or tag someone who can review/merge this change? thanks! |
clintropolis
suggested changes
Oct 11, 2018
when 1b74f29 added support to handle archive tasks, it introduced a new matching group for the regular expression in parseTaskId which shifted the indexing for resulting matches (i.e. m). to simplify things, i am making marking the outer group as don't-capture-just-group (?:) to keep the matching result consistent. as a result, type will be populated using m[3], m[2], or m[1]. m[4] will always be the datsource; m[5] will be the timestamp. this change adds unit tests to demonstrate the expected parseTaskId output for various tasks type supported. it also covers the error case when taskId doesn't match the regular expression.
this updates parseTaskId in iUtils.coffee which uses a somwhat strict regular expression to parse a given task id and extract type, datasource, and time. this simply removes throwing the error and falls back to 'other' for type leaving dataSource and dataTime alone. in case of a match failure, they would just default to undefined which isn't a blocker to render /indexing-service view.
alperkokmen
force-pushed
the
fallback-for-parseTaskId
branch
from
77575d7
to
ea4f4db
Compare
|
@clintropolis i found out |
clintropolis
approved these changes
Oct 11, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this updates
parseTaskIdiniUtils.coffeewhich uses a somwhat strict regular expression to parse a given task id and extracttype,datasource, and time (relates to #3 and #9).this simply removes throwing the error and falls back to
'other'for type leavingdataSourceanddataTimealone. in case of a match failure, they would just default to undefined which isn't a blocker to render/indexing-serviceview.