convert service name to port number #2446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #2445 |
|
Hi, |
|
MacOS has /etc/services though, don't know about WSL? We need to put some thought in this, so that the code doesn't become ugly and it works on every OS supported and on docker. And we work around a weird bug in the old openssl we're using. I anyway wanted to complete the sieve implementation. Don't know how difficult it is yet to add/backport the service resolution into it. Fallback would be a private LUT (lookup table) , i.e. |
|
see comment in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with
$ ./testssl.sh news.newshosting.com:nntps