Skip to content

Commit

Permalink
Fix incorrect type in ManifestRegistrar#finalize!
Browse files Browse the repository at this point in the history
`#finalize!` is sending the basename directly to `#call`, which expects
a Dry::System::Identifier.

This means that if you configure a `registrations_dir`, putting any file
in that directory will lead to an exception during finalization.

This appears to have been introduced during #208
  • Loading branch information
alassek committed Jun 13, 2022
1 parent 1c5e3ae commit 9737bc6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/dry/system/manifest_registrar.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def initialize(container)
# @api private
def finalize!
::Dir[registrations_dir.join(RB_GLOB)].sort.each do |file|
call(File.basename(file, RB_EXT))
call(Identifier.new(File.basename(file, RB_EXT)))
end
end

Expand Down

0 comments on commit 9737bc6

Please sign in to comment.