Fetching data from redux for admin categories #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-jindal
suggested changes
May 25, 2019
|
|
||
| export const fetchCategory =()=>{ | ||
| return dispatch =>{ | ||
| fetch('https://jsonplaceholder.typicode.com/posts') |
There was a problem hiding this comment.
@Subhang23 Use axios and from what url are you fetching?
| export const fetchCategory =()=>{ | ||
| return dispatch =>{ | ||
| fetch('https://jsonplaceholder.typicode.com/posts') | ||
| .then(response => response.json()) |
There was a problem hiding this comment.
Convert the response to json in one then itself.
two then's are Not required.
|
@Subhang23 Also rename the adminCategoryReducer/Action to adminAction/Reducer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
Changes: Getting data for the table using redux