Use os.walk for recursing+add ignored dirs #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Larivact-patch-1 Conflicts: inotify/adapters.py
…m-master Conflicts: inotify/adapters.py
…regarding directory access events..
* fixed order of add-watch/scandir to ensure not missing any directory created between scanning directory and adding watch * try to import walk from scandir module if python's version os module is missing scandir functionality * adjusted README accordingly * adjusted tests accordingly - fixed merge/implementation of ignored_dirs parameter for the tree-watchers * added testcase - did a small fix I have commited in another branch (remove duplicate IN_MOVED_TO handling) to have clean testcases (- maybe some other minor adjustments btw... check history...)
…ded" and missed to fix the "trusty" (v4 kernel?) version)
|
Any news regarding this pull request? |
|
@codethief I wanted to merge all the collected fixes and changes into one branch and into one complete PR (so that at least I have a more complete version to continue with). |
|
This is too big of a PR. Please squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quite properly implemented merge of #30 from @Larivact + #31 from @innlym + #48 from @xlotlu into master.
Would be fine if You could merge this or similiar as I dislike the idea staying on a fork not in sync with upstream to have a working version.
(Still some fixes/cahnges missing here as I did not merge this proposal into my main fixes branch yet.)