Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlink Support #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Symlink Support #5

wants to merge 3 commits into from

Conversation

ayushr2
Copy link
Contributor

@ayushr2 ayushr2 commented Jun 12, 2019

Resolves #4. I think inline files should also work now.

@coveralls
Copy link

coveralls commented Jun 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 25

  • 4 of 12 (33.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 61.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extent.go 4 12 33.33%
Files with Coverage Reduction New Missed Lines %
inode.go 1 45.71%
Totals Coverage Status
Change from base Build 21: -0.3%
Covered Lines: 714
Relevant Lines: 1155
💛 - Coveralls

dsoprea
dsoprea requested changes Jun 13, 2019
View reviewed changes
Copy link
Owner

@dsoprea dsoprea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add another Read() unit-test to test this. Use one of the existing Read() tests as a template.

extent.go Outdated Show resolved Hide resolved
extent.go Outdated Show resolved Hide resolved
extent.go Outdated Show resolved Hide resolved
extent.go Outdated Show resolved Hide resolved
extent.go Show resolved Hide resolved
@ayushr2
Copy link
Contributor Author

ayushr2 commented Jun 19, 2019

Added a test.

@davissp14
Copy link

Thoughts on merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsoprea dsoprea dsoprea requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Symlinks
4 participants
@ayushr2 @coveralls @davissp14 @dsoprea