Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate randomness #9

Closed
wants to merge 11 commits into from
Closed

Add generate randomness #9

wants to merge 11 commits into from

Conversation

kim201212
Copy link
Member

No description provided.

Copy link
Member

@rootwarp rootwarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this?

@kim201212 kim201212 self-assigned this Feb 13, 2023
@kim201212
Copy link
Member Author

close #15

Copy link
Member

@rootwarp rootwarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May ./test/dump.json should be removed.

contribution/contribution.js Show resolved Hide resolved
index.js Show resolved Hide resolved
@rootwarp
Copy link
Member

In my env. error occurs.

rootwarp@LT-026 ~/g/d/dsrv-kzg-ceremony random > ./index.js ceremony a002479f-782b-48a5-b3b9-fa18c87446f1
Starting ceremony...
Decoding...
Update Power of Tau...
updatePowerOfTau 7177057640311544215210810364117382200091468669765550551577723128495801892862n
/Users/rootwarp/git/dsrv/dsrv-kzg-ceremony/node_modules/@noble/curves/lib/abstract/weierstrass.js:113
            throw new Error('Expected valid bigint: 0 < bigint < curve.n');
                  ^

Error: Expected valid bigint: 0 < bigint < curve.n
    at assertGE (/Users/rootwarp/git/dsrv/dsrv-kzg-ceremony/node_modules/@noble/curves/lib/abstract/weierstrass.js:113:19)
    at Point.multiply (/Users/rootwarp/git/dsrv/dsrv-kzg-ceremony/node_modules/@noble/curves/lib/abstract/weierstrass.js:404:13)
    at Object.contribute (/Users/rootwarp/git/dsrv/dsrv-kzg-ceremony/contribution/contribution.js:42:46)
    at Command.<anonymous> (/Users/rootwarp/git/dsrv/dsrv-kzg-ceremony/index.js:85:43)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v19.6.0

As I debug the code,

contribute.contribute(contributions, rand) function takes just single value of rand argument, not array type. did you check this?

659f691

@kim201212
Copy link
Member Author

@rootwarp

494b8d6

I fixed it at the above commit and tested it. 🙏

Copy link
Member

@rootwarp rootwarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootwarp
Copy link
Member

@rootwarp

494b8d6

I fixed it at the above commit and tested it. 🙏

@kim201212 Branch seems conflicted. can you check this?

@rootwarp
Copy link
Member

@kim201212 As I remember this code already merged.
This should be close.

@kim201212
Copy link
Member Author

It already merged, Close

@kim201212 kim201212 closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants