Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change composition of classes in order to resolve containment issues #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lruslan
Copy link

@lruslan lruslan commented Aug 10, 2015

  1. replace 'include' with 'contain' - this will make all subclasses of the module to be contained by base class
  2. make plugins follow general sequence and reload stackdriver services in uniform way
  3. stackdriver::config::redhat and stackdriver::config::debian explicitely require $apikey (otherwise stackdriver agent won't start)
  4. remove inheritance from base class "inherits stackdriver", as it caused all containment issues. Subclasses should access 'global' level parameters from 'class stackdriver' using full name: $stackdriver::ensure, $stackdriver::svc
  5. moved installation and configuration parts to own submodules, just to keep base class cleaner:
    contain stackdriver::install
    contain stackdriver::config
    contain stackdriver::service

@dstockman
Copy link
Owner

Hey @lruslan, can you fix up this PR and resend? I'll get it pulled in ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants