Fixes for building with clang-cl on Windows #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with clang-cl:
.../ir_emit.c(275,8): error: unused variable 'handle' [-Werror,-Wunused-variable]
275 | void *handle = NULL;
| ^~~~~~
clang-cl defines this on Windows, resulting in an error.
.../ir.h(32,10): error: '__ORDER_LITTLE_ENDIAN__' macro redefined [-Werror,-Wmacro-redefined]
32 | # define __ORDER_LITTLE_ENDIAN__ 1
| ^
<built-in>(39,9): note: previous definition is here
39 | #define __ORDER_LITTLE_ENDIAN__ 1234
When compiling on Windows with clang-cl, __has_builtin(__builtin_ctzl) will evaluate to true, but a long on Windows is only 32 bits, resulting in an incorrect implementation. Move the _WIN64 block ahead of the general block so that it gets the 64 bit version. Fixes dstogov#101.
dstogov
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits are just minor incompatibilities in the compiler, but the ntzl one caused incorrect behaviour in
ir_bitqueue_pop().