Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easing freebsd build approach. #62

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

devnexen
Copy link
Contributor

No description provided.

Makefile Outdated
Comment on lines 54 to 56
override CFLAGS += -I/usr/local/include
override BUILD_CFLAGS += -I/usr/local/include
LDFLAGS += -L/usr/local/lib -lutil
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need /usr/local/include?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what symbols are imported from util?

Copy link
Contributor Author

@devnexen devnexen Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need /usr/local/include?

capstone (in FreeBSD non system packages are in /usr/local)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what symbols are imported from util?

kinfo_getproc

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capstone (in FreeBSD non system packages are in /usr/local)

Did you build capstone yourself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, FreeBSD package system put all in /usr/local

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile Outdated
Comment on lines 52 to 53
CC=clang
BUILD_CC=clang
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should use cc?

Makefile Outdated
TARGET = x86_64
OS = linux
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may use $(shell uname -s) for OS detection.

Copy link
Owner

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

@dstogov dstogov merged commit 0c5725d into dstogov:master Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants