Introducing bash-parser dependency #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parro-it
commented
Jun 2, 2017
src/preparser.js
Outdated
| // const preparser = function (input) { | ||
| // input = parseEnvVariables(input); | ||
| // return input; | ||
| // }; | ||
|
|
||
| module.exports = preparser; |
There was a problem hiding this comment.
When we will use it, bash-parser has already taken care of env parameter expansion at this point, so the preparser should be superflous
|
We're tearing apart Vorpal right now anyway, so I think it would be a good idea to play with i there. |
Kreijstal
reviewed
Jan 22, 2019
| @@ -10,6 +10,7 @@ var expand = require('./../util/expand'); | |||
|
|
|||
| var head = { | |||
| exec: function exec(args, options) { | |||
| console.log({ args: args }); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an investigatory PR to study the introduction of a POSIX compliant shell code parser using bash-parser.
I studied the cash workflow, and I think the majority of changes in source code would concern Vorpal.
They could be implemented directly there (in vorpal core) or we could patch vorpal and implement it only for cash.