-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC chiploads, chip thinning & overrides #19
Open
spanner888
wants to merge
43
commits into
dubstar-04:master
Choose a base branch
from
spanner888:tidied_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addon works as normal in FreeCAD. To run standalone just run "python3 PathFeedsAndSpeedsGui.py" Just a draft idea ATM, heave not done any validation, or imperial units and have left Toolcontroller drop down & button in place for now.
eg for chiploads, CNC limits etc also removed minor test text from materials.csv added meterials.csv
but need get materials & chipload materials all same..... AND TEST LOTS - dif materials/tool.dia!!!!!
cade v messy with comments/prints...
(ie before cnc had wings to stiffen it and got better) ...and ONLY looking at Al ATM!!!
moving calc of cl back into existing method
maybe not be best exception handling when running in gui!!
& tweaked data for testing
...still need change to only ONE load csv method!!
still need sort out data but minimal tests = nice
PROBABLY WORKING := cl increases as woc reduces rpm stays same power reduces. just no idea if by corect amount of changes/values!!!
...other wise get situation where upm can be increased ...MASSIVLEY ??while user ever actually want to increase rpm?? guess can change other vars/conditions.... maybe an option??? also what about ss & cl overides - similar issue(s)?
output seems same...diff only seemded show no/quotes but got lost - did not see chiploads OH OK - gave that combined file dif name!!!! so these two files MAYBE CHANGED AND changes *NOT* tested!!!
…mostly comments tidy
So new branch, merged csvChipLoad, tehn merged standalone ...& stuffed about.....just with merging.. maybe a bit tweaked to get scripted use running - that was beofre cooked dinner.... Now tweaking & got standalone mode running - well displays gui. Some bit part working - eg Chipload lookup - at least on init! ...and plenty errors.
…se standalone code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works from scripted console use, script included. GUI needs updates to cater for this - not yet implemented. Makes extensive use of csv import from FreeCAD user imm, for materials, inclduing surface speeds and chiploads (as y intercept & slope values).
Three modes:
Run as FreeCAD Addon in Path workbench.
Run as Standalone GUI ie runs without FreeCAD
Tools are loaded from a csv file, instead of FreeCAD Job, toolcontrollers
TODO: imperial units for standalone gui mode.
Command line
Demo script provided
At present only way to enable chip thinning TODO: add to both gui versions.
automatic overides to suit your CNC min/max rpm and power.
In addition to above new features are:
csv Load of existing materials, including Ssurface cutting speeds, Machine power factor etc.
csv Load Chiploads (added to existing materials csv)
csv load of Tools in Standalone mode.
csv load could also be basis for more data, and user settings, such as CNC limits, Tools.
Thanks to user imm for suggesting and providing excelent code to implement above.
Optional Chip Thinning calculations (but only via command line at present (Help wanted :). Based on common formula eg https://www.harveyperformance.com/in-the-loupe/combat-chip-thinning/
Notes:
#This is RADIAL chip thinning chipload adjustment, ie not axial as can be calculated for round tip cutters, like ballnose etc
#Adjustment/formula unlikely to work for very small WOC, for example when adjusted chipload becomes significantly larger than WOC.
#Internet 'wisdom' does not seem to provide any definite value/situation for when tool rubbing will occur.
#Above reference site does say that chipload thinning adjustment will "...hopefully {adjust chips to be} thick enough to avoid rubbing".
Collated/curated csv data for chipload calculation from linear curve fit. This has taken a lot of work to find usable data, ie where materials can be matched with Surface Speed data and for reliability of data. This needs more effort and more eyes on it.
Optional skip rpm overide if rpm is < overide_value (eg stop say a 20mm endmill being overidden from 2000rpm to 10000rpm!). Only available from comamnd line at present, using fsAddon.rpm_overide_reduce_only = True
TODO: Extended power factor range, using curve fit. Curve fit is done, should be trivial to add using above csv load.
TODO & More bugs listed in code and at https://github.com/dubstar-04/FeedsAndSpeeds, including issues with vertical feed and Drilling calculations are currently disabled.
TODO: More in my notes.....