Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support compress request body #403

Merged
merged 11 commits into from
Feb 12, 2025
Merged

support compress request body #403

merged 11 commits into from
Feb 12, 2025

Conversation

zuisong
Copy link
Contributor

@zuisong zuisong commented Jan 22, 2025

@zuisong zuisong force-pushed the compress-request-body branch from d7f708a to f85194a Compare January 22, 2025 10:21
blyxxyz
blyxxyz reviewed Jan 22, 2025
View reviewed changes
@blyxxyz blyxxyz mentioned this pull request Jan 22, 2025
Open
@zuisong zuisong marked this pull request as ready for review January 22, 2025 14:25
blyxxyz
blyxxyz reviewed Jan 22, 2025
View reviewed changes
zuisong
zuisong commented Jan 22, 2025
View reviewed changes
@zuisong zuisong force-pushed the compress-request-body branch from e64e14f to 1ec0267 Compare January 23, 2025 01:19
@zuisong zuisong marked this pull request as draft January 23, 2025 05:31
@zuisong zuisong marked this pull request as ready for review January 23, 2025 06:06
@ducaale ducaale mentioned this pull request Feb 19, 2023
Open
28 tasks
ducaale
ducaale reviewed Jan 31, 2025
View reviewed changes
@zuisong zuisong marked this pull request as draft February 4, 2025 14:26
@zuisong zuisong force-pushed the compress-request-body branch from 59f4f89 to d9026f1 Compare February 4, 2025 14:47
@zuisong zuisong marked this pull request as ready for review February 4, 2025 14:56
@zuisong
Copy link
Contributor Author

zuisong commented Feb 5, 2025

I've incorporated all your suggested improvements. 😄

Could you please review for any other areas needing improvement?

Should I squash into a single commit before merging the code?

blyxxyz
blyxxyz reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, almost there!

@zuisong zuisong force-pushed the compress-request-body branch from 4b8c353 to e9a386f Compare February 6, 2025 01:41
@zuisong
Copy link
Contributor Author

zuisong commented Feb 6, 2025

thanks, I've incorporated all your suggested improvements.

@ducaale
Copy link
Owner

ducaale commented Feb 10, 2025

The changes look good to me. Is there anything else we want to address before this can be merged @blyxxyz?

blyxxyz
blyxxyz approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

blyxxyz
blyxxyz reviewed Feb 12, 2025
View reviewed changes
@ducaale ducaale merged commit 4873dc9 into ducaale:master Feb 12, 2025
9 checks passed
@zuisong zuisong deleted the compress-request-body branch February 13, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxxyz blyxxyz blyxxyz approved these changes

@ducaale ducaale ducaale left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuisong @ducaale @blyxxyz