Skip to content

Commit

Permalink
remove matrix for now (wasn't being used properly)
Browse files Browse the repository at this point in the history
  • Loading branch information
jraymakers committed Jun 22, 2024
1 parent ab85c8b commit 9abf3fb
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/NodeJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ jobs:
runs-on: ubuntu-latest
# needs: set-up-npm
# continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
env:
TARGET_ARCH: ${{ matrix.target_arch }}
# env:
# TARGET_ARCH: ${{ matrix.target_arch }}
# DUCKDB_NODE_BUILD_CACHE: 0
strategy:
matrix:
# strategy:
# matrix:
# node.js current support policy to be found at https://github.com/duckdb/duckdb-node/tree/main/#Supported-Node-versions
# node: [ '12', '14', '16', '17', '18', '19', '20', '21']
node: ['20']
target_arch: [ x64, arm64 ]
# node: ['20']
# target_arch: [ x64, arm64 ]
# isRelease:
# - ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
# exclude:
Expand Down Expand Up @@ -120,11 +120,11 @@ jobs:
runs-on: macos-latest
# needs: linux-nodejs
# continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
strategy:
matrix:
target_arch: [ x64, arm64 ]
# strategy:
# matrix:
# target_arch: [ x64, arm64 ]
# node: [ '12', '14', '16', '17', '18', '19', '20', '21']
node: ['18', '20', '22']
# node: ['18', '20', '22']
# isRelease:
# - ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
# exclude:
Expand All @@ -144,8 +144,8 @@ jobs:
# node: 14
# these older versions of NodeJS don't have M1 support

env:
TARGET_ARCH: ${{ matrix.target_arch }}
# env:
# TARGET_ARCH: ${{ matrix.target_arch }}
# DUCKDB_NODE_BUILD_CACHE: 0
steps:
- uses: actions/checkout@v3
Expand Down

0 comments on commit 9abf3fb

Please sign in to comment.