testing variables for zip url

duckdb · Jun 30, 2024 · fb077ee · fb077ee
1 parent 6db6d57
commit fb077ee
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 10 deletions.
diff --git a/alt/bindings/binding.gyp b/alt/bindings/binding.gyp
@@ -3,12 +3,29 @@
     {
       'target_name': 'fetch_libduckdb',
       'type': 'none',
+      'conditions': [
+        ['OS=="linux"', {
+          'variables': {
+            'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-linux-amd64.zip',
+          },
+        }],
+        ['OS=="mac"', {
+          'variables': {
+            'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-osx-universal.zip',
+          },
+        }],
+        ['OS=="win"', {
+          'variables': {
+            'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-windows-amd64.zip',
+          },
+        }],
+      ],
       'actions': [
         {
           'action_name': 'run_fetch_libduckdb_script',
           'message': 'Running fetch libduckdb script',
           'inputs': [],
-          'action': ['python3', '<(module_root_dir)/scripts/fetch_libduckdb.py', '<(OS)', '<(module_root_dir)/libduckdb'],
+          'action': ['python3', '<(module_root_dir)/scripts/fetch_libduckdb.py', '<(OS)', '<(module_root_dir)/libduckdb', '<(zip_url)'],
           'outputs': ['<(module_root_dir)/libduckdb/libduckdb.zip'],
         },
       ],

diff --git a/alt/bindings/scripts/fetch_libduckdb.py b/alt/bindings/scripts/fetch_libduckdb.py
@@ -9,24 +9,31 @@
   "win": "https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-windows-amd64.zip",
 }
 
-libduckdb_file_names_for_os = {
-  "linux": ["duckdb.h", "libduckdb.so"],
-  "mac": ["duckdb.h", "libduckdb.dylib"],
-  "win": ["duckdb.h", "libduckdb.lib", "libduckdb.dll"],
-}
+# libduckdb_file_names_for_os = {
+#   "linux": ["duckdb.h", "libduckdb.so"],
+#   "mac": ["duckdb.h", "libduckdb.dylib"],
+#   "win": ["duckdb.h", "libduckdb.lib", "libduckdb.dll"],
+# }
 
 os_name = sys.argv[1]
 output_dir = sys.argv[2]
+zip_url = sys.argv[3]
+
+print("os_name: " + os_name)
+print("output_dir: " + output_dir)
+print("zip_url: " + zip_url)
 
 libduckdb_zip_url = libduckdb_zip_url_for_os[os_name]
-libduckdb_file_names = libduckdb_file_names_for_os[os_name]
+# libduckdb_file_names = libduckdb_file_names_for_os[os_name]
 
 libduckdb_zip_path = os.path.join(output_dir, "libduckdb.zip")
 print("fetching: " + libduckdb_zip_url)
 urllib.request.urlretrieve(libduckdb_zip_url, libduckdb_zip_path)
 
 zip = zipfile.ZipFile(libduckdb_zip_path)
+print("extracting: " + zip.namelist())
+zip.extractall(output_dir)
 
-for file_name in libduckdb_file_names:
-  print("extracting: " + file_name)
-  zip.extract(file_name, output_dir)
+# for file_name in libduckdb_file_names:
+#   print("extracting: " + file_name)
+#   zip.extract(file_name, output_dir)