default duckdb_api config #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elefeint
approved these changes
Dec 12, 2024
| ], | ||
| }); | ||
| }); | ||
| test('overriding duckdb_api', async () => { |
There was a problem hiding this comment.
overriding duckdb_api is not really expected (although possible). All layers above the closest-to-duckdb are expected to set custom_user_agent instead, which is additive (all layers will be preserved).
There was a problem hiding this comment.
I needed to make at least the bindings layer overridable, so the api layer can override it. But I agree it's unclear whether the ability to override this at the api level is useful, even though I support it for completeness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both the bindings and the api layers, set a (different) default value for the
duckdb_apiconfig.Ensure this works whether or not the user provides an explicit config; if they do, ensure it's overridable.
The default
duckdb_apivalue for the bindings layer is:node-neo-bindingsThe default for the api layer (which most people will use) is:
node-neo-api