Update Settings: Remove ripple for disabled ppro items #5546
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
force-pushed
the
feature/mike/update-settings/remove-ripple-for-disabled-ppro-items
branch
from
6b46744 to
22aee04
Compare
ensure no ripples are shown when the click listener is set to null
mikescamell
force-pushed
the
feature/mike/update-settings/remove-ripple-for-disabled-ppro-items
branch
from
22aee04 to
cc83ee4
Compare
nalcalag
approved these changes
Feb 10, 2025
mikescamell
deleted the
feature/mike/update-settings/remove-ripple-for-disabled-ppro-items
branch
tr4200812
pushed a commit
to tr4200812/Dutifully-Adelaide-
that referenced
this pull request
Mar 7, 2025
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209246799465871/f ### Description Added ripple effect to clickable settings list items and removed background from non-clickable items to improve visual feedback and user interaction consistency. ### Steps to test this PR _Settings List Items_ - [x] Navigate to settings - [x] Purchase Privacy Pro Monthly - [x] Verify Privacy Pro (VPN, PIR, ITR) items are clickable and have a ripple - [x] Cancel Privacy Pro - [x] Wait 5mins for expiration - [x] Navigate out of settings and back in - [x] Verify Privacy Pro items (VPN, PIR, ITR) have no ripple effect ### UI changes **Before** https://github.com/user-attachments/assets/c13d1be6-dc71-4e08-bad8-8a08ac295d50 **After** https://github.com/user-attachments/assets/e33059d7-9698-473b-8a76-c09ca29c7c6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209246799465871/f
Description
Added ripple effect to clickable settings list items and removed background from non-clickable items to improve visual feedback and user interaction consistency.
Steps to test this PR
Settings List Items
UI changes
Before
Screen_recording_20250127_184447.mp4
After
Screen_recording_20250127_183546.mp4