Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dax dialog scrolling for small devices #5573

Merged

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jan 31, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1208088786036608

Description

Fix Dax dialog being cut off on the bottom of the pre-onbaording screen in small devices

Steps to test this PR

  • Fresh install on a small-screen device
  • Tap 'Let's do it!' to view the comparison chart Dax dialog
  • Ensure the dialog is fully visible (not cut off at the bottom)
  • Verify the dialog is scrollable and the 'Choose your browser' button is accessible

UI changes

Before After
Screenshot 2025-02-03 at 15 09 21 Screenshot 2025-02-03 at 15 09 37

@nalcalag
Copy link
Contributor Author

nalcalag commented Jan 31, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag force-pushed the feature/noelia/release_highlight_onboarding_to_all_users branch from 5deffb0 to a844aaf Compare February 3, 2025 13:22
@nalcalag nalcalag mentioned this pull request Feb 3, 2025
7 tasks
@nalcalag nalcalag force-pushed the feature/noelia/release_highlight_onboarding_to_all_users branch 2 times, most recently from 03de1c6 to 9625e45 Compare February 3, 2025 15:14
@nalcalag nalcalag force-pushed the feature/noelia/fix_onboarding_scroll_small_devices branch from abafa75 to bd455d5 Compare February 3, 2025 15:14
@nalcalag nalcalag marked this pull request as ready for review February 3, 2025 15:15
@0nko 0nko self-requested a review February 3, 2025 16:07
@nalcalag nalcalag force-pushed the feature/noelia/fix_onboarding_scroll_small_devices branch from bd455d5 to 78cafaa Compare February 3, 2025 16:18
@0nko
Copy link
Member

0nko commented Feb 3, 2025

@nalcalag The privacy protections dialog works as expected, nice work!

After continuing with the onboarding, however, I noticed that these screens are still not scrollable (see the screenshots below). A similar fix could be applied to them as well, WDYT?

image

@nalcalag
Copy link
Contributor Author

nalcalag commented Feb 3, 2025

After continuing with the onboarding, however, I noticed that these screens are still not scrollable (see the screenshots below). A similar fix could be applied to them as well, WDYT?

@0nko thanks for the review! I can't see the images you attached, but I assume you're referring to the Dax dialogs on the new tab page once the browser is visible. I agree they should be scrollable, but since they don't block browser usage and fixing this would require handling the keyboard responsiveness within the browser content, it's out of scope for this task. Hope that makes sense!

Copy link
Member

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🏅

Base automatically changed from feature/noelia/release_highlight_onboarding_to_all_users to develop February 4, 2025 01:40
@nalcalag nalcalag requested a review from malmstein as a code owner February 4, 2025 01:40
@nalcalag nalcalag force-pushed the feature/noelia/fix_onboarding_scroll_small_devices branch from 78cafaa to 4e82c40 Compare February 5, 2025 11:42
@nalcalag nalcalag merged commit 6282dba into develop Feb 5, 2025
6 checks passed
@nalcalag nalcalag deleted the feature/noelia/fix_onboarding_scroll_small_devices branch February 5, 2025 12:00
LukasPaczos pushed a commit that referenced this pull request Feb 7, 2025
Task/Issue URL: https://app.asana.com/0/488551667048375/1208088786036608

### Description
Fix Dax dialog being cut off on the bottom of the pre-onbaording screen
in small devices

### Steps to test this PR

- [x]  Fresh install on a small-screen device
- [x]  Tap 'Let's do it!' to view the comparison chart Dax dialog
- [x]  Ensure the dialog is fully visible (not cut off at the bottom)
- [x] Verify the dialog is scrollable and the 'Choose your browser'
button is accessible

### UI changes
| Before  | After |
| ------ | ----- |
<img width="561" alt="Screenshot 2025-02-03 at 15 09 21"
src="https://github.com/user-attachments/assets/cf63c7d4-1f6c-410f-bef6-9aceaffff0d0"
/>|<img width="561" alt="Screenshot 2025-02-03 at 15 09 37"
src="https://github.com/user-attachments/assets/74b50a57-132c-4a1e-9440-81ec2d65a82a"
/>|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants