-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dax dialog scrolling for small devices #5573
Fix Dax dialog scrolling for small devices #5573
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5deffb0
to
a844aaf
Compare
03de1c6
to
9625e45
Compare
abafa75
to
bd455d5
Compare
bd455d5
to
78cafaa
Compare
@nalcalag The privacy protections dialog works as expected, nice work! After continuing with the onboarding, however, I noticed that these screens are still not scrollable (see the screenshots below). A similar fix could be applied to them as well, WDYT? ![]() |
@0nko thanks for the review! I can't see the images you attached, but I assume you're referring to the Dax dialogs on the new tab page once the browser is visible. I agree they should be scrollable, but since they don't block browser usage and fixing this would require handling the keyboard responsiveness within the browser content, it's out of scope for this task. Hope that makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 🏅
78cafaa
to
4e82c40
Compare
Task/Issue URL: https://app.asana.com/0/488551667048375/1208088786036608 ### Description Fix Dax dialog being cut off on the bottom of the pre-onbaording screen in small devices ### Steps to test this PR - [x] Fresh install on a small-screen device - [x] Tap 'Let's do it!' to view the comparison chart Dax dialog - [x] Ensure the dialog is fully visible (not cut off at the bottom) - [x] Verify the dialog is scrollable and the 'Choose your browser' button is accessible ### UI changes | Before | After | | ------ | ----- | <img width="561" alt="Screenshot 2025-02-03 at 15 09 21" src="https://github.com/user-attachments/assets/cf63c7d4-1f6c-410f-bef6-9aceaffff0d0" />|<img width="561" alt="Screenshot 2025-02-03 at 15 09 37" src="https://github.com/user-attachments/assets/74b50a57-132c-4a1e-9440-81ec2d65a82a" />|
Task/Issue URL: https://app.asana.com/0/488551667048375/1208088786036608
Description
Fix Dax dialog being cut off on the bottom of the pre-onbaording screen in small devices
Steps to test this PR
UI changes