Duck Player custom error #5698
Open
Duck Player custom error #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgurgel
force-pushed
the
feature/mgurgel/duckplayer-custom-error
branch
from
fa757fd to
6a43c68
Compare
mgurgel
force-pushed
the
feature/mgurgel/duckplayer-custom-error
branch
from
13f1ebd to
9d36ba9
Compare
CrisBarreiro
requested changes
Mar 4, 2025
| @@ -247,6 +271,24 @@ class DuckPlayerJSHelper @Inject constructor( | |||
| else -> null | |||
| } | |||
| } | |||
| "reportYouTubeError" -> { | |||
| val impressionPixelName: DuckPlayerPixelName = when (data?.getString("error")) { | |||
| "age-restricted" -> DUCK_PLAYER_YOUTUBE_ERROR_AGE_RESTRICTED_IMPRESSION | |||
There was a problem hiding this comment.
nit: Extract to constants
| @@ -127,6 +137,9 @@ class DuckPlayerJSHelper @Inject constructor( | |||
| jsonObject.put("platform", JSONObject("""{ name: "android" }""")) | |||
| jsonObject.put("locale", java.util.Locale.getDefault().language) | |||
| jsonObject.put("env", if (appBuildConfig.isDebug) "development" else "production") | |||
|
|
|||
| // Custom Error Settings | |||
| jsonObject.getJSONObject("settings").put("customError", getCustomErrorSettings()) | |||
There was a problem hiding this comment.
We shouldn't pass this from native when CSS already has access to the RC JSON. See DuckPlayerContentScopeConfigPlugin
| * | ||
| * @return True if should show a custom error view, false otherwise. | ||
| */ | ||
| fun shouldShowCustomError(): Boolean |
There was a problem hiding this comment.
Similar to what I said above, we shouldn't expose this on the public API, but rather rely on CSS to get this values internally from the RC JSON
| @@ -33,4 +33,12 @@ enum class DuckPlayerPixelName(override val pixelName: String) : Pixel.PixelName | |||
| DUCK_PLAYER_SETTINGS_PRESSED("duckplayer_setting_pressed"), | |||
| DUCK_PLAYER_NEWTAB_SETTING_ON("duckplayer_newtab_setting-on"), | |||
| DUCK_PLAYER_NEWTAB_SETTING_OFF("duckplayer_newtab_setting-off"), | |||
| DUCK_PLAYER_YOUTUBE_ERROR_SIGN_IN_REQUIRED_IMPRESSION("duckplayer_youtube-signin-error_impression"), | |||
There was a problem hiding this comment.
Since these pixels are fired from the app module, they should be moved to AppPixelName. Other modules should never access the impl directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209459625347014
Description
Shows a custom error screen when Duck Player detects an error message in the YouTube embed
Steps to test this PR
UI changes