moves autofill service (and activities) to its own process #5720
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonfortep
force-pushed
the
feature/cristian/autofill/move_autofill_service_to_own_process
branch
from
2ecd9a6 to
1f53db5
Compare
cmonfortep
commented
Mar 2, 2025
| @@ -100,7 +100,9 @@ class RealAutofillService : AutofillService() { | |||
|
|
|||
| callback.onSuccess(response) | |||
| }.onFailure { | |||
| pixel.fire(AutofillPixelNames.AUTOFILL_SERVICE_CRASH, mapOf("message" to it.extractExceptionCause())) | |||
| if (it !is kotlinx.coroutines.CancellationException) { | |||
There was a problem hiding this comment.
While testing I've noticed some crash pixels related when the coroutine is cancelled (before completion). That doesn't represent a crash, so skipping if that's the case.
karlenDimla
reviewed
Mar 5, 2025
| @@ -110,6 +111,14 @@ open class DuckDuckGoApplication : HasDaggerInjector, MultiProcessApplication() | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| runInSecondaryProcessNamed(AUTOFILL_SERVICE_PROCESS_NAME) { | |||
There was a problem hiding this comment.
Once you have rebased with develop, you wouldn’t need any changes in this file.
There was a problem hiding this comment.
Just pushed the actual changes, so this should be solved.
cmonfortep
force-pushed
the
feature/cristian/autofill/move_autofill_service_to_own_process
branch
from
1f53db5 to
9bba237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200156640058969/1209537052601451
Description
Moves Autofill Service (and activities) to its own process
Steps to test this PR
Feature 1
then smoke test the service
UI changes