Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Switcher Animation: Translations #5724

Open
wants to merge 24 commits into
base: feature/mike/tab-switcher-tile-animation/display-real-tracker-count
Choose a base branch
from

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Mar 3, 2025

Task/Issue URL: https://app.asana.com/0/1207908166761516/1209560463368002

Description

Added localized strings for tracker blocking statistics animation in the tab switcher across multiple languages. The strings display the number of trackers blocked in the last 7 days.

Steps to test this PR

Verify translations

  • Switch device language to different supported locales and verify the tracker blocking statistics text appears correctly
  • Verify placeholder formatting works correctly with different numeric values
  • Check that HTML formatting (bold tags) renders properly across languages

Verify string usage

  • Open tab switcher and confirm tracker blocking statistics are displayed
  • Verify the "in the last 7 days" text appears correctly below the main statistics

Copy link
Contributor Author

mikescamell commented Mar 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mikescamell mikescamell changed the title Tab Switcher Tile Animation: Translations Tab Switcher Animation: Translations Mar 3, 2025
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/translations branch from c60974a to fa5ceaf Compare March 4, 2025 14:23
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/display-real-tracker-count branch from f4309c1 to c5263f4 Compare March 4, 2025 14:23
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/display-real-tracker-count branch from c5263f4 to b005223 Compare March 6, 2025 17:16
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/translations branch 2 times, most recently from 6b63d29 to a5c2d0d Compare March 6, 2025 18:07
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/display-real-tracker-count branch from b005223 to 4fe8ab9 Compare March 6, 2025 18:08
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/translations branch from a5c2d0d to faeee79 Compare March 7, 2025 07:50
@0nko 0nko self-assigned this Mar 7, 2025
Copy link
Member

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Translate strings to values-sk
Translate strings to values-cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants