Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-selection: Tab closing #5725

Open
wants to merge 6 commits into
base: feature/ondrej/tab-multi-selection-bookmarking
Choose a base branch
from

Conversation

0nko
Copy link
Member

@0nko 0nko commented Mar 3, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209118961868652

Description

This PR implements the tab-closing functionality for selected tabs.

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Copy link
Member Author

0nko commented Mar 3, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko changed the title Implement the tab closing functionality logic Multi-selection: Tab closing Mar 3, 2025
@0nko 0nko marked this pull request as ready for review March 3, 2025 20:30
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tab-closing branch from 6d73bb3 to a88f83f Compare March 3, 2025 20:39
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-bookmarking branch 2 times, most recently from 0e745d2 to 3db6a74 Compare March 4, 2025 11:00
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tab-closing branch from a88f83f to 00b77dc Compare March 4, 2025 11:00
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-bookmarking branch from 3db6a74 to c80ecea Compare March 4, 2025 12:52
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tab-closing branch 2 times, most recently from 187e0a3 to d1fe060 Compare March 5, 2025 10:01
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-bookmarking branch from c80ecea to 2cc684b Compare March 5, 2025 10:02
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tab-closing branch from d1fe060 to 687ca92 Compare March 5, 2025 16:56
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-bookmarking branch from 2cc684b to cf6b2c2 Compare March 5, 2025 16:56
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tab-closing branch from 3710f98 to e15a447 Compare March 6, 2025 14:12
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-bookmarking branch 2 times, most recently from 3412b1c to fc005e5 Compare March 10, 2025 10:07
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tab-closing branch from e15a447 to a77c491 Compare March 10, 2025 10:07
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-bookmarking branch from fc005e5 to cf68075 Compare March 10, 2025 10:58
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tab-closing branch from a77c491 to 8dfb332 Compare March 10, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant