-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-selection: Tab closing #5725
Open
0nko
wants to merge
6
commits into
feature/ondrej/tab-multi-selection-bookmarking
Choose a base branch
from
feature/ondrej/tab-multi-selection-tab-closing
base: feature/ondrej/tab-multi-selection-bookmarking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multi-selection: Tab closing #5725
0nko
wants to merge
6
commits into
feature/ondrej/tab-multi-selection-bookmarking
from
feature/ondrej/tab-multi-selection-tab-closing
+226
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6d73bb3
to
a88f83f
Compare
0e745d2
to
3db6a74
Compare
a88f83f
to
00b77dc
Compare
3db6a74
to
c80ecea
Compare
187e0a3
to
d1fe060
Compare
c80ecea
to
2cc684b
Compare
d1fe060
to
687ca92
Compare
2cc684b
to
cf6b2c2
Compare
3710f98
to
e15a447
Compare
3412b1c
to
fc005e5
Compare
e15a447
to
a77c491
Compare
fc005e5
to
cf68075
Compare
a77c491
to
8dfb332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209118961868652
Description
This PR implements the tab-closing functionality for selected tabs.
Steps to test this PR
Feature 1
UI changes