Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert favorites when bookmark is favorite and no index #3442

Open
wants to merge 1 commit into
base: release/1.111.0
Choose a base branch
from

Conversation

jotaemepereira
Copy link
Collaborator

@jotaemepereira jotaemepereira commented Oct 23, 2024

Task/Issue URL: https://app.asana.com/0/1201048563534612/1208595122638622/f
Tech Design URL:
CC:

Description:
It fixes new bookmarks not being added to favorites from the dialog when no favorites index is passed.

Steps to test this PR:

  1. Create new bookmark from the dialog or by going to the new tab page and tapping the add favorite cell
  2. Check the ‘Add as favorite’ box
  3. Add the bookmark
  4. The bookmark should be part of the new tab page array of favorites (you should also check is a favorite in the panel and in the bookmarks manager)

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@jotaemepereira jotaemepereira changed the base branch from main to release/1.111.0 October 23, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant