Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrivateReports and Child Sites #3792

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

brianhall
Copy link
Collaborator

@brianhall brianhall commented Jan 28, 2025

Task/Issue URL: https://app.asana.com/0/608920331025329/1209246105419581/f
Tech Design URL:
CC:

Description:
Adds PrivateReports as a new parent broker.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
1.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 56f40af

Copy link
Contributor

github-actions bot commented Feb 5, 2025

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Feb 5, 2025
@brianhall brianhall changed the base branch from main to release/1.125.0 February 5, 2025 15:56
@brianhall brianhall removed the stale label Feb 5, 2025
@brianhall brianhall changed the title Add PrivateReports Add PrivateReports and Child Sites Feb 5, 2025
@THISISDINOSAUR
Copy link
Contributor

I got an action failed error when running via debug mode, is that okay?

Screenshot 2025-02-05 at 5 30 54 PM Screenshot 2025-02-05 at 5 31 19 PM

@brianhall
Copy link
Collaborator Author

Did debug mode actually error out, or just say “no results found”?

PrivateReports is strict about only returning results that are close matches, so the “too many results” path is quite common.

@THISISDINOSAUR
Copy link
Contributor

Yeah it gave me the actionFailed error

@brianhall
Copy link
Collaborator Author

Hmm, are you running C-S-S >= 7.13.0 by chance?

@THISISDINOSAUR
Copy link
Contributor

It looks like it's 7.10.0, but then if this branch is using that, won't it still be on merge?

@brianhall
Copy link
Collaborator Author

Ah, that’s the issue, but I’m a bit confused because it looks like C-S-S was bumped to 7.15.0 on main yesterday. Maybe I’m missing how this works conceptually.

@THISISDINOSAUR
Copy link
Contributor

It'll have missed the release cut off on Monday. We'll either have to wait and just merge this into main, or merge the CSS bump into the release branch too. IMO were better off waiting, I don't see any reason for this to bypass the usual checks/cadence

@brianhall brianhall changed the base branch from release/1.125.0 to main February 5, 2025 18:20
@brianhall
Copy link
Collaborator Author

Ah, bummer, but agreed. Updated the base branch to main.

Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I merged in main to test it properly, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants