-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrivateReports and Child Sites #3792
base: main
Are you sure you want to change the base?
Conversation
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
Did debug mode actually error out, or just say “no results found”? PrivateReports is strict about only returning results that are close matches, so the “too many results” path is quite common. |
Yeah it gave me the actionFailed error |
Hmm, are you running C-S-S >= 7.13.0 by chance? |
It looks like it's 7.10.0, but then if this branch is using that, won't it still be on merge? |
Ah, that’s the issue, but I’m a bit confused because it looks like C-S-S was bumped to 7.15.0 on |
It'll have missed the release cut off on Monday. We'll either have to wait and just merge this into main, or merge the CSS bump into the release branch too. IMO were better off waiting, I don't see any reason for this to bypass the usual checks/cadence |
Ah, bummer, but agreed. Updated the base branch to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw I merged in main to test it properly, LGTM!
Task/Issue URL: https://app.asana.com/0/608920331025329/1209246105419581/f
Tech Design URL:
CC:
Description:
Adds PrivateReports as a new parent broker.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
1.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation