-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for unknown actions in TDS #60
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing those! Not sure why we should not merge this? Will BSK pull those tests automatically and block releases until this is fixed? Do you know if we have the same issue on Android and Windows?
tracker-radar-tests/TR-domain-matching/tracker_radar_reference.json
Outdated
Show resolved
Hide resolved
@kdzwinel we can definitely merge it, its just that it would essentially freeze those products at the current ref test HEAD, and so they would miss out on other test updates until they are updated to handle this case. |
We're heading to auto updating; we should mark them as failures or similar on the other platforms. |
I'm happy to merge this if that's the consensus, it will however break TDS file parsing so tests will just fail hard, no way to create a platform exception for that without fixing the issue. |
So the individual cases can't be disabled just the entire suite? If that's the case: An alternative is making a new suite purely for v4 and disabling on all other platforms for now.
|
https://app.asana.com/0/1171671347221384/1203125805176391/f
Tests for unrecognized custom "action"s in tracker radar entries. This cannot be merged until we fix JSON test parsing in MacOS browser (at minimum), otherwise it will fail at file load. Can be tested with the extension once PR is merged