Add functions for Create/Modify/Delete User, Associate/Disassociate Group, and User to url.Values #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateGroupWithUser, and DisassociateGroupFromUser
…nto params using the url struct tag. Update CreateUser, ModifyUser to use params as input to match existing patterns. Based on work in duosecurity#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely based on the work done in #12 with the requested changes to match the existing pattern to pass params into CreateUser and ModifyUser.
Added a reflect based parsing function of User to url.Value based params. This removes the "github.com/google/go-querystring/query" dependency that #12 added, and provides more or less the same convenience functionality for the developer.
Note, I removed the omitempty tag options on User, as between CreateUser and ModifyUser all params are optional. Thus all fields are omitted if they are empty (eg. have zero values). Only fields that are used as params have been tagged with
url.