Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM/CSJ build & dependency reduction #42

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lukashroch
Copy link
Contributor

@lukashroch lukashroch commented Jan 18, 2025

Description

Motivation and Context

How Has This Been Tested?

 | "@duosecurity/duo_universal"
node10 | ✅
node16 (from CJS) | ✅ (CJS)
node16 (from ESM) | ✅ (ESM)
bundler | ✅

Types of Changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Function client.createAuthUrl('username', 'state') now returns a promise.

// before
const authUrl = client.createAuthUrl('username', 'state');

// after
const authUrl = await client.createAuthUrl('username', 'state');

- support esm/cjs treeshakable without transient dependencies to support various envs
- tsup and extracts version as constant from the json file
@lukashroch lukashroch force-pushed the esm branch 3 times, most recently from 671f745 to 488e053 Compare January 18, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NextJS ENOENT: no such file or directory Error when trying to create Client
1 participant