Add http_proxy parameter to Client
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gcoxmoz the manual approval necessary to run CI timed out since it's been a month (sorry about that). IIUC |
|
@AaronAtDuo Re-pushed; thanks for looking. |
jeffreyparker
approved these changes
Jan 17, 2024
|
@gcoxmoz Thanks for the PR! |
|
NP. Side note, it would be really great if this could get released+pypi'ed soonish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
http_proxysupport for hosts who need to go through a proxy to reach Duo servers.Motivation and Context
duosecurity/duo_universal_php#5 is a PR that was accepted for "the same functionality" in "the same type of code" / a sibling project.
How Has This Been Tested?
Tests added for args+kwargs passthrough.
Types of Changes