Split strings out from HTML to allow for proper translation. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the moment this breaks multisite. I'm working on fixing that. |
mbish
commented
Dec 19, 2023
mbish
commented
Dec 19, 2023
mbish
changed the title
spencermaxfield
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to make our plugin translatable we need to split out the human-facing strings from various
other code (HTML) and string identifiers (such as a menu slug). This is mostly done through printf.
Motivation and Context
Mostly for WordPress review. Even though internationalization is marked as "optional" we've already
gotten feedback for not being compatible with automatic translation standards so lets just get this
into the right format.
How Has This Been Tested?
Manually running the plugin and make sure things look right.