Remove code to workaround old IIS behavior #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was some old code carrier over from the previous plugin which worked around IIS issues at
the time. This has sense been fixed https://ruslany.net/2008/08/update-for-iis-70-fastcgi-module/
and support for the affected version ended in January of 2020. Consequently we no longer need this
code.
Motivation and Context
Without this workaround we don't need to access or sanitize as many globals. Also we aren't mucking
around with URLs when we don't have to and it makes the scanners happier. Win, win, win.
Types of Changes