Adds configuration to the resource pools builder #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on tests. |
dbernstein
approved these changes
May 20, 2024
|
@nwoodward : just a note here: I ran the new unit test this against the develop branch and it passed without the changes to the ehcache version and the AppDriver. So this may fix the problem for you but it won't necessarily. |
|
@dbernstein Do you see the same pool errors in your Mill instances? Maybe it's something else with my environment. |
|
@nwoodward : I will check. In the meantime, you can rebase this PR in order to have a docker image based on this PR to test in your AWS environment. |
|
@nwoodward : confirmed: I'm seeing the same problem. |
|
Closing this one because it is superceded by #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #65