Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Updated to allow ARAM/Blitz item sets from Lolalytics and more #428

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

corylulu
Copy link

@corylulu corylulu commented Sep 10, 2018

  • Now has new option that can be checked to import ARAM/Blitz item sets from Lolalytics (some stuff still needs to be tested and worked out, but it seems to work from my initial tests)
  • Now uses the full site names for itemsets that aren't split (since the names are short enough in those cases). I never liked trying to parse the abbreviations because most of them weren't immediately recognizable, so I got rid of them in places they weren't needed (i.e. when item-sets weren't broken up)
  • Changed how Lolalytics item set sorting ordering works so that all Most Frequent groups appeared before Highest Win Rate instead of interlacing them because of how those particular item sets are displayed, it makes it very hard to consume.
  • Added Oracle Elixir to consumables list globally since the client will filter unavailable items out anyways.

Some of this could be cleaned up, I'm sure. I know I could have minimized certain functions, but wanted to match the existing structure as best as I could initially, then planned to change from there. I will likely be adding more to this PR in the next day or so.

Now has new option that can be checked to import ARAM/Blitz item sets from Lolalytics

Now uses the full site names for itemsets that aren't split (since the names are short enough in those cases)
@corylulu
Copy link
Author

Also, see #429 regarding build error. Not sure how to fix it, but it wasn't building even before I change anything.

@@ -19,9 +19,9 @@ aws.config.update({
secretAccessKey: process.env.AWS_SECRET_ACCESS_KEY
});

const s3 = Promise.promisifyAll(new aws.S3({
const s3 = new aws.S3({
params: {Bucket: 'dustinblackman-championify-coverage'}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix for #429

@dustinblackman
Copy link
Owner

This is brilliant, thank you very much! Give me until tomorrow to give it a proper review, and to verify my build scripts work on my new machine.

@corylulu
Copy link
Author

corylulu commented Sep 12, 2018

@dustinblackman Great, but you'll wanna test it before the patch because unfortunately, Blitz is going back in development for a while again. So I guess my timing was pretty bad xD

There are a couple things in there that I had to change to get it to build with my setup, but none are breaking. (1) The require('runas'); was giving me problems, but it wasn't being used anyways, so I moved it inside elevate() (where it was being used) and (2) the #429 issue mentioned above.

Also, you can thank /u/Lolalytics for adding the blitz.json for me (swiftly too)

@corylulu
Copy link
Author

Fuck off, AppVeyor, it built fine!

@dustinblackman
Copy link
Owner

Sorry for the delay on this. I haven't had the time to myself with the flu going around to properly test this locally. I'm hoping to today or tomorrow.

@Kizsa
Copy link

Kizsa commented Sep 18, 2018

I am waiting for this like a little kid :D

@corylulu
Copy link
Author

@Kizsa Well if you want an unofficial build, here ya go.

@dustinblackman No worries, Blitz is back in the workshop right now anyways, so the update doesn't offer too much at the moment besides the addition of Lolalytic ARAM sets. I may see if I can get Lolalytics can add in rotating game modes as well.

@Kizsa
Copy link

Kizsa commented Sep 19, 2018

@Kizsa Well if you want an unofficial build, here ya go.

@dustinblackman No worries, Blitz is back in the workshop right now anyways, so the update doesn't offer too much at the moment besides the addition of Lolalytic ARAM sets. I may see if I can get Lolalytics can add in rotating game modes as well.

Installation has failed.
Failed to extract installer

Looks like I have to wait :P

@tammenha
Copy link

tammenha commented Dec 7, 2018

@dustinblackman No worries, Blitz is back in the workshop right now anyways, so the update doesn't offer too much at the moment besides the addition of Lolalytic ARAM sets. I may see if I can get Lolalytics can add in rotating game modes as well.

I just wanted to let you know that Nexus Blitz is now back in the game until January 22, 2019.

@Infinitay
Copy link

Any update on this?

@SXRWahrheit
Copy link

Would love to see this pulled for ARAM now that LolFlavor is gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants