-
Notifications
You must be signed in to change notification settings - Fork 157
Updated to allow ARAM/Blitz item sets from Lolalytics and more #428
base: master
Are you sure you want to change the base?
Conversation
Now has new option that can be checked to import ARAM/Blitz item sets from Lolalytics Now uses the full site names for itemsets that aren't split (since the names are short enough in those cases)
Also, see #429 regarding build error. Not sure how to fix it, but it wasn't building even before I change anything. |
@@ -19,9 +19,9 @@ aws.config.update({ | |||
secretAccessKey: process.env.AWS_SECRET_ACCESS_KEY | |||
}); | |||
|
|||
const s3 = Promise.promisifyAll(new aws.S3({ | |||
const s3 = new aws.S3({ | |||
params: {Bucket: 'dustinblackman-championify-coverage'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix for #429
This is brilliant, thank you very much! Give me until tomorrow to give it a proper review, and to verify my build scripts work on my new machine. |
@dustinblackman Great, but you'll wanna test it before the patch because unfortunately, Blitz is going back in development for a while again. So I guess my timing was pretty bad xD There are a couple things in there that I had to change to get it to build with my setup, but none are breaking. (1) The Also, you can thank /u/Lolalytics for adding the blitz.json for me (swiftly too) |
Fuck off, AppVeyor, it built fine! |
Sorry for the delay on this. I haven't had the time to myself with the flu going around to properly test this locally. I'm hoping to today or tomorrow. |
I am waiting for this like a little kid :D |
@Kizsa Well if you want an unofficial build, here ya go. @dustinblackman No worries, Blitz is back in the workshop right now anyways, so the update doesn't offer too much at the moment besides the addition of Lolalytic ARAM sets. I may see if I can get Lolalytics can add in rotating game modes as well. |
Installation has failed. Looks like I have to wait :P |
I just wanted to let you know that Nexus Blitz is now back in the game until January 22, 2019. |
Any update on this? |
Would love to see this pulled for ARAM now that LolFlavor is gone. |
Some of this could be cleaned up, I'm sure. I know I could have minimized certain functions, but wanted to match the existing structure as best as I could initially, then planned to change from there. I will likely be adding more to this PR in the next day or so.