Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): remove link from year display in YearPost component, mark Spark GitHub Actions post as featured #558

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

duyet
Copy link
Owner

@duyet duyet commented Nov 23, 2024

Summary by Sourcery

Fix the YearPost component by removing the link from the year display and enhance the blog by marking the Spark GitHub Actions post as featured.

Bug Fixes:

  • Remove the link from the year display in the YearPost component to prevent incorrect navigation.

Enhancements:

  • Mark the 'Running Spark in GitHub Actions' post as featured to highlight its importance.

Copy link
Contributor

sourcery-ai bot commented Nov 23, 2024

Reviewer's Guide by Sourcery

This PR makes two distinct changes: it removes the clickable link from the year display in the YearPost component and marks the Spark GitHub Actions blog post as a featured post.

Updated class diagram for Spark GitHub Actions post

classDiagram
    class SparkGitHubActionsPost {
        title: String
        date: Date
        author: String
        category: String
        tags: List
        +featured: Boolean
    }
    note for SparkGitHubActionsPost "The 'featured' attribute was added."
Loading

File-Level Changes

Change Details Files
Remove year link functionality from the year display
  • Remove Link component wrapper around the year display
  • Year is now displayed as plain text instead of a clickable link
apps/blog/components/year-post.tsx
Update blog post metadata to mark as featured
  • Add featured: true to the frontmatter metadata
apps/blog/_posts/2023/05/spark-github-actions.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 5:21am
cv 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 5:21am
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 5:21am

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @duyet - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant