Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events periodically check and update events #44

Merged

Conversation

Mulugruntz
Copy link
Contributor

@Mulugruntz Mulugruntz commented Feb 18, 2024

  • Git: Get automatically possibly existing branches
  • Git: Auto commit
  • Git: Auto push on existing branch
  • Git: Auto push on new branch
  • Github: Create new PR if it does not exist

@Mulugruntz Mulugruntz self-assigned this Feb 18, 2024
@Mulugruntz Mulugruntz linked an issue Feb 18, 2024 that may be closed by this pull request
@Mulugruntz Mulugruntz force-pushed the sgiffard/43-events-periodically-check-and-update-events branch 2 times, most recently from 40289be to 3fd890a Compare February 20, 2024 19:07
@Mulugruntz Mulugruntz marked this pull request as ready for review February 22, 2024 15:22
@Mulugruntz
Copy link
Contributor Author

Opening this for review. But it'll only be truly ready when Hoyo will release another Event.

PR #45 should be automatically updated when that happens. For now it's running on my local env.

Copy link
Member

@maalni maalni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Can you push this image to repo registry?

To split into sub-categories:
- S3
- Celery

Signed-off-by: Samuel Giffard <[email protected]>
Signed-off-by: Samuel Giffard <[email protected]>
Refactor of the code to have customizable paths. Useful, as the event data might come either from local (mount) or from a remote repository (git clone).

Signed-off-by: Samuel Giffard <[email protected]>
Does branch and commit management.

Signed-off-by: Samuel Giffard <[email protected]>
Does PR management.

Signed-off-by: Samuel Giffard <[email protected]>
Signed-off-by: Samuel Giffard <[email protected]>
- Two Celery tasks removed.
- Stop the run early when no events.

Signed-off-by: Samuel Giffard <[email protected]>
@Mulugruntz Mulugruntz force-pushed the sgiffard/43-events-periodically-check-and-update-events branch from 01d40b6 to 3da0a18 Compare February 24, 2024 22:22
@Mulugruntz
Copy link
Contributor Author

I did a rebase because of merge conflict.

About the registry, I never used the GitHub one before. I'll look into that.
Please mind that I made a stack with compose. So, you might want to use the whole compose instead.

I'll see about the registry either tomorrow or in the first half of next week. No promise though.

@Mulugruntz Mulugruntz merged commit 6a4d149 into main Feb 24, 2024
2 checks passed
@Mulugruntz Mulugruntz deleted the sgiffard/43-events-periodically-check-and-update-events branch February 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events: Periodically check and update events
2 participants