Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate links to sidekiq/sidekiq #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate links to sidekiq/sidekiq #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Sidekiq/ActiveRecordArgument:
Description: "ActiveRecord arguments are not valid parameters to a Sidekiq worker"
StyleGuide: "https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
StyleGuide: "https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
Enabled: true
VersionAdded: '0.5'
# Look for uses within variables and methods that are passed to perform_*
Expand All @@ -11,14 +11,14 @@ Sidekiq/ActiveRecordArgument:

Sidekiq/ConstArgument:
Description: "Classes and objects are not valid parameters to a Sidekiq worker"
StyleGuide: "https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
StyleGuide: "https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
Enabled: true
VersionAdded: '0.5'
Severity: warning

Sidekiq/DateTimeArgument:
Description: "Use strings or integers to represent dates/times, not objects"
StyleGuide: "https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
StyleGuide: "https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
Enabled: true
VersionAdded: '0.5'
Severity: warning
Expand All @@ -39,14 +39,14 @@ Sidekiq/InlinePerform:

Sidekiq/KeywordArguments:
Description: "Do not use keyword arguments in a sidekiq worker's perform method"
StyleGuide: "https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
StyleGuide: "https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
Enabled: true
VersionAdded: '0.5'
Severity: warning

Sidekiq/NamedQueue:
Description: "Minimize the number of queues used for sidekiq"
StyleGuide: "https://github.com/mperham/sidekiq/wiki/Advanced-Options#queues"
StyleGuide: "https://github.com/sidekiq/sidekiq/wiki/Advanced-Options#queues"
Enabled: true
VersionAdded: '0.5'
AllowedNames:
Expand All @@ -56,7 +56,7 @@ Sidekiq/NamedQueue:

Sidekiq/QueueInTransaction:
Description: "Do not queue workers within a transaction"
StyleGuide: "https://github.com/mperham/sidekiq/wiki/FAQ#why-am-i-seeing-a-lot-of-cant-find-modelname-with-id12345-errors-with-sidekiq"
StyleGuide: "https://github.com/sidekiq/sidekiq/wiki/FAQ#why-am-i-seeing-a-lot-of-cant-find-modelname-with-id12345-errors-with-sidekiq"
Enabled: true
VersionAdded: '0.5'

Expand All @@ -67,7 +67,7 @@ Sidekiq/Sleep:

Sidekiq/SymbolArgument:
Description: 'Use strings instead of symbols as parameters to a worker'
StyleGuide: "https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
StyleGuide: "https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple"
Enabled: true
VersionAdded: '0.5'
Severity: warning
Expand Down
14 changes: 7 additions & 7 deletions docs/modules/ROOT/pages/cops_sidekiq.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ MyWorker.perform_async(5)

=== References

* https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple
* https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple

== Sidekiq/ConstArgument

Expand Down Expand Up @@ -90,7 +90,7 @@ MyWorker.perform_async(MyClass::MY_CONSTANT)

=== References

* https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple
* https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple

== Sidekiq/DateTimeArgument

Expand Down Expand Up @@ -160,7 +160,7 @@ MyWorker.perform_async(Time.now.mday)

=== References

* https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple
* https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple

== Sidekiq/IncludedInModule

Expand Down Expand Up @@ -294,7 +294,7 @@ end

=== References

* https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple
* https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple

== Sidekiq/NamedQueue

Expand Down Expand Up @@ -366,7 +366,7 @@ end

=== References

* https://github.com/mperham/sidekiq/wiki/Advanced-Options#queues
* https://github.com/sidekiq/sidekiq/wiki/Advanced-Options#queues

== Sidekiq/QueueInTransaction

Expand Down Expand Up @@ -419,7 +419,7 @@ end

=== References

* https://github.com/mperham/sidekiq/wiki/FAQ#why-am-i-seeing-a-lot-of-cant-find-modelname-with-id12345-errors-with-sidekiq
* https://github.com/sidekiq/sidekiq/wiki/FAQ#why-am-i-seeing-a-lot-of-cant-find-modelname-with-id12345-errors-with-sidekiq

== Sidekiq/Sleep

Expand Down Expand Up @@ -500,4 +500,4 @@ MyWorker.perform_async('foo')

=== References

* https://github.com/mperham/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple
* https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple